Re: desktop font + PATCH for 82565

[Alex Larsson <alexl redhat com>]

On Wed, 29 May 2002, Frank Worsley wrote:

> > 
> > Great work Frank!
> > 
> 
> Thanks a lot. :)
> 
> > 
> > You should use get_default_zoom_level instead of eel_preferences_get_enum
> > (actually, if the auto value were setup like it is in the list view then
> > you could remove get_default_zoom_level altogether and just use
> > default_zoom_level_auto_value directly)
> 
> Good call, the auto value is there so I will use that.
> 
> > It seems like a bad idea to add another argument here; how is the caller
> > supposed to know if the font table should be updated?  I think it would be
> > better if you compared new_level with view->details->zoom_level and if
> > they're not equal then update the font table.
> 
> I'm not sure if that does the trick. But I will rethink the way I did
> that.
> 
> > This doesn't really matter much since all we care about is how it looks
> > but FYI each PANGO_SCALE is different by a factor of 1.2 (e.g.
> > PANGO_SCALE_XXXX_LARGE = 1.2 * 1.2 * PANGO_SCALE_XX_LARGE and
> > PANGO_SCALE_XXX_SMALL = (1 / 1.2) * PANGO_SCALE_XX_SMALL)
> 
> I see, yes that makes sense. I fix that up properly. 

Did you finish up the new version of the patch?


-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy gay grifter living undercover at Ringling Bros. Circus. She's a 
supernatural hypochondriac bodyguard with her own daytime radio talk show. 
They fight crime!