Re: [Nautilus-list] [PATCH] creating launchers with Nautilus

[Gaute Lindkvist <lindkvis stud ntnu no>]

> > ? src/file-manager/nautilus-launcher-dialog.c
> > ? src/file-manager/nautilus-launcher-dialog.h
>
> Don't forget to do a cvs add. In fact, you should do this now, because it
> has no effect until you commit. And it's a common mistake to forget to add
> new source files.
>

Oops.. but I do not have cvs access, and thus cvs add fails. I remember
Kjartan Maraas created an account for me almost a year ago for translation
of the nautilus manual, but I haven't used it, and do not remember the
password.

>
> > +    launcher_dialog (path, fm_directory_view_get_containing_window
> (FM_DIRECTORY_VIEW (callback_data)), NULL);
>
> It's generally considered bad style to pass in a string that's "adopted" by
> the function you're calling. If the path is not "adopted", then you have a
> storage leak here, and need a g_free.
>

I fixed the two others. This one, I'm not really sure of, since I'm mostly
a Java-programmer. What is the correct way of solving this?

Gaute