Re: [Nautilus-list] [PATCH] creating launchers with Nautilus

[Darin Adler <darin bentspoon com>]

> ? src/file-manager/nautilus-launcher-dialog.c
> ? src/file-manager/nautilus-launcher-dialog.h

Don't forget to do a cvs add. In fact, you should do this now, because it
has no effect until you commit. And it's a common mistake to forget to add
new source files.

It's impossible for me to review this patch without seeing the contents of
the new source files.

> +    char * path;

A blank line here please.

> +    path = (char *) nautilus_directory_get_uri(FM_DIRECTORY_VIEW
(callback_data)->details->model);

Please, no type cast here.

> +    launcher_dialog (path, fm_directory_view_get_containing_window
(FM_DIRECTORY_VIEW (callback_data)), NULL);

It's generally considered bad style to pass in a string that's "adopted" by
the function you're calling. If the path is not "adopted", then you have a
storage leak here, and need a g_free.

    -- Darin