Re: [Nautilus-list] Possible patch for bug #73368



On 3/5/02 9:24 AM, "Jens Finke" <jens triq net> wrote:

> bug #73368 says that opening an image with a '!' character in the filename
> doesn't work with Eye of Gnome. Well, it seems to me that this is more a
> general nautilus bug, because it uses such an URI directly as vfs:
> moniker, when trying to obtain a BonoboStream object for it:
> 
> moniker_str = g_strconcat ("vfs:", uri, NULL);
> stream = bonobo_get_object (moniker_str, "IDL:Bonobo/Stream:1.0",
>                           &ev);
> 
> Since '!' is used as delimiter for moniker attributes this isn't going to
> work.
> 
> Attached is a patch which fixes this. It's likely that I oversee a
> situation in which this patch may raise other problems, but I think it is
> safe.

Your analysis is right on the money, and the patch looks good to me. Feel
free to commit.

Are there any other characters that are reserved by the moniker system that
we should be concerned about?

    -- Darin





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]