Re: PATCH: use timeouts for progress dialogs
- From: Dave Camp <dave ximian com>
- To: Frank Worsley <fworsley shaw ca>
- Cc: nautilus-list gnome org
- Subject: Re: PATCH: use timeouts for progress dialogs
- Date: 30 Jul 2002 17:05:18 -0400
This looks like a good thing to have, it does feel much snappier.
However, since it doesn't fix any serious bugs, and is a fairly big
patch, I think it should probably wait for 2.1. Alex or Darin might
disagree.
Some comments:
It looks like you leak all of saved information if the dialog is
destroyed without being shown.
nautilus_file_operation_progress_stop_timeout() should be named
nautilus_file_operation_progress_pause_timeout() to reflect the fact
that it can be resumed.
You should probably create_ui in nautilus_file_operation_progress_new()
if FALSE is sent for use_timeout. If you do this, the realize handler
shouldn't be necessary.
Out of curiosity, how did you choose 1200 milliseconds?
On Mon, 2002-07-29 at 15:12, Frank Worsley wrote:
> Again a slightly updated patch that stops the show timeout while we are
> waiting for user input and resumes it afterwards. This way if you are
> copying one file and you get the overwrite confirmation we don't have to
> pop up the progress dialog before showing the confirmation. It looks way
> better this way.
>
> - Frank
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]