Re: [Nautilus-list] toolbar icons patch

[Jens Finke <jens triq net>]

Hi Darin,

On Wed, 20 Feb 2002, Darin Adler wrote:
> But you could make the code even nicer by using gtk_image_new_from_file
> rather than gdk_pixbuf_new_from_file. Then you could get rid of the
> g_object_ref/g_object_unref, and make image be a GtkWidget * rather than a
> gpointer.
>
> Also, the line:
>
> > +            if (image == NULL) return;
>
> does not match the Nautilus coding style. It needs to use 3 lines and
> braces.
>
> If you take my first suggestion, then you can add a line of code that sets
> image to NULL before the if statement, and then do the check for NULL and
> return after the if statement, and you won't need two different return
> statements.

I've commited the patch together with your above suggestions.

Regards,

  Jens

-- 
"Wer die Freiheit aufgibt, um Sicherheit zu gewinnen, wird am Ende beides
verlieren." -- Benjamin Franklin