Re: [Nautilus-list] [PATCH] for bug 43302

[Alex Larsson <alexl redhat com>]

On Wed, 24 Apr 2002, Gaute Lindkvist wrote:

> Then now...
> 
> Here is the patch that fixes all the beforementioned issues. As an added
> bonus it also checks to see if we have permission to read the file.
> 
> If this is ok, you have to commit it for me, since I do not have
> cvs-access.
> If not, lets try one more time ;-).

I'm very sorry.  :)

You leak the handle from the:
result = gnome_vfs_open (&handle, theme_to_install_path, GNOME_VFS_OPEN_READ);
You need to gnome_vfs_close (handle).

You also leak the quoted filenames.

I promise, I'm not deliberately trying to be cruel here...

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a sword-wielding crooked ex-con in a wheelchair. She's a disco-crazy 
out-of-work wrestler who don't take no shit from nobody. They fight crime!