Re: [Nautilus-list] [PATCH] for bug 43302

> I think you leak user_themes_directory and theme_name when you return
> early.
Ok.. this is easy enough.

> I also think that there may be escape issues with the filenames in the
> commandlines :(. What if they have spaces or pipes in them or something.

Hmm.. didn't think of that. Would passing the parameters through
g_shell_quote do?

Do you have any more objections before I submit the updated patch? :-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]