Re: [Nautilus-list] [PATCH] for bug 43302

On Tue, 23 Apr 2002, Gaute Lindkvist wrote:

> > Doesn't the (status != 0) catch the case where (status < 0) ?
> >
> Doooh! *slapsforehead*. Is the rest of the patch ok though?

Man. I feel cruel today...

I think you leak user_themes_directory and theme_name when you return 

I also think that there may be escape issues with the filenames in the 
commandlines :(. What if they have spaces or pipes in them or something.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an uncontrollable coffee-fuelled barbarian moving from town to town, 
helping folk in trouble. She's a transdimensional kleptomaniac bounty hunter 
in the witness protection program. They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]