Re: [Nautilus-list] [PATCH] for bug 43302

[Alex Larsson <alexl redhat com>]

On Tue, 23 Apr 2002, Gaute Lindkvist wrote:

> First. I think I fixed all the issues mentioned above.
> 
> > +		if (status < 0) {
> > +			return NAUTILUS_THEME_INSTALL_FAILED;
> > +		}
> > +		else if (status != 0) {
> > +			return NAUTILUS_THEME_INSTALL_FAILED;
> > +		}
> > The first if seems unnecessary.
> 
> Here I have to disagree. system() returns -1 if the fork fails, see the
> manpage for system. This might not happen very often, but if it does,
> we're better safe than sorry.

Doesn't the (status != 0) catch the case where (status < 0) ?

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a leather-clad chivalrous gentleman spy who knows the secret of the alien 
invasion. She's a ditzy belly-dancing Hell's Angel in the witness protection 
program. They fight crime!