Re: [Nautilus-list] [PATCH] for bug 43302



On Tue, 2002-04-23 at 15:32, Gaute Lindkvist wrote:
> First. I think I fixed all the issues mentioned above.
> 
> > +		if (status < 0) {
> > +			return NAUTILUS_THEME_INSTALL_FAILED;
> > +		}
> > +		else if (status != 0) {
> > +			return NAUTILUS_THEME_INSTALL_FAILED;
> > +		}
> > The first if seems unnecessary.
> 
> Here I have to disagree. system() returns -1 if the fork fails, see the
> manpage for system. This might not happen very often, but if it does,
> we're better safe than sorry.

I think there's a Do'h in here...   status < 0 is caught by the status
!= 0 so the first one can be eliminated....

Damon.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]