Re: [Nautilus-list] [PATCH] for bug 77174 (Nautilus sorts in opposite order when "sort in reverse order" chosen)

On Sun, 2002-04-07 at 14:38, Alex Larsson wrote:
> Hmmm. It seems fm_list_model_add_file() has the same problem.
> Also, it seems strange that SORT_ASCENDING means reverse sort. That 

Maybe (I also had a hard time deciding this). In any case the choice is
dictated by the following code, in src/file-manager/fm-list-view.c,
set_sort_order_from_metadata_and_preferences ():

	gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE
					      sort_reversed ? GTK_SORT_ASCENDING : GTK_SORT_DESCENDING);


This choice might be easier to justify if we think about the case of
sorting by size.  By default we should put smaller files after bigger
files, hence descending in the default case and ascending when the sort
is reversed.

What do you think?

> doesn't sound right. Maybe we're getting model->details->order wrong 
> instead.
> -- 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    alexl redhat com    alla lysator liu se 
> He's a leather-clad coffee-fuelled grifter from the Mississippi delta. She's 
> an artistic impetuous schoolgirl who dreams of becoming Elvis. They fight 
> crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]