Re: [Nautilus-list] [PATCH] for bug 77174 (Nautilus sorts in opposite order when "sort in reverse order" chosen)

[Alex Larsson <alexl redhat com>]

On Sun, 7 Apr 2002, David Emory Watson wrote:

> 
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/nautilus/ChangeLog,v
retrieving revision 1.5181
diff -p -u -r1.5181 ChangeLog
--- ChangeLog	5 Apr 2002 18:25:54 -0000	1.5181
+++ ChangeLog	7 Apr 2002 19:15:13 -0000
@@ -1,3 +1,15 @@
+2002-04-07  David Emory Watson  <dwatson cs ucr edu>
+
+	* src/file-manager/fm-list-model.c:
+	(fm_list_model_compare_func): Should be GTK_SORT_ASCENDING when
+	sort_reversed, bug 77174.
+
 2002-04-06  David Emory Watson  <dwatson cs ucr edu>
 
 	* src/file-manager/fm-list-model.c:
Index: src/file-manager/fm-list-model.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-list-model.c,v
retrieving revision 1.7
diff -p -u -r1.7 fm-list-model.c
--- src/file-manager/fm-list-model.c	11 Mar 2002 10:17:49 -0000	1.7
+++ src/file-manager/fm-list-model.c	7 Apr 2002 19:15:22 -0000
@@ -371,7 +371,7 @@ fm_list_model_compare_func (gconstpointe
 	result = nautilus_file_compare_for_sort (file1, file2,
 						 fm_list_model_get_nautilus_file_sort_type (model),
 						 model->details->sort_directories_first,
-						 (model->details->order == GTK_SORT_DESCENDING));
+						 (model->details->order == GTK_SORT_ASCENDING));
 
 	return result;
 }


Hmmm. It seems fm_list_model_add_file() has the same problem.

Also, it seems strange that SORT_ASCENDING means reverse sort. That 
doesn't sound right. Maybe we're getting model->details->order wrong 
instead.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a leather-clad coffee-fuelled grifter from the Mississippi delta. She's 
an artistic impetuous schoolgirl who dreams of becoming Elvis. They fight 
crime!