Re: [Nautilus-list] file changes not updating in 1.0.5



On Wed, 24 Oct 2001, Alex Larsson wrote:

> With fam, when changing the size of a file, it does not immediately update 
> in a nautilus icon view. Adding or removing files does. But changes only 
> seem to show up when you click on the icon. 
> 
> I've traced this a bit, and the fam interaction seems ok. It seems the 
> problem is in the new work-queue code or something.

Yes, the problem seems to be in the work-queue code.

First of all, according to the comments in process_new_files this patch 
seems to be missing:

Index: fm-directory-view.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-directory-view.c,v
retrieving revision 1.473
diff -u -p -r1.473 fm-directory-view.c
--- fm-directory-view.c	2001/10/18 23:31:14	1.473
+++ fm-directory-view.c	2001/10/24 20:33:51
@@ -2022,18 +2025,33 @@ process_new_files (FMDirectoryView *view
 	 */
 	for (node = new_changed_files; node != NULL; node = node->next) {
 		file = NAUTILUS_FILE (node->data);
 		if (ready_to_load (file)) {
 			if (g_hash_table_lookup (non_ready_files, file) != NULL) {
 				g_hash_table_remove (non_ready_files, file);
 				nautilus_file_unref (file);
 				if (still_should_show_file (view, file)) {
 					nautilus_file_ref (file);
 					old_added_files = g_list_prepend (old_added_files, file);
 				}
 			} else {
 				nautilus_file_ref (file);
 				old_changed_files = g_list_prepend (old_changed_files, file);
 			}
+		} else {
+			if (g_hash_table_lookup (non_ready_files, file) == NULL) {
+				g_print ("process_new_files() - inserting file into non_ready_files hashtable\n");
+				nautilus_file_ref (file);
+				g_hash_table_insert (non_ready_files, file, file);
+			}
 		}
 	}
 	nautilus_file_list_free (new_changed_files);

Secondly,  if the ready_to_load() calls here fails for a newly changed 
file (because file_info is not read yet), how are we supposed to get a new 
call when file_info finished loading???

mjs, how is this supposed to work?

/ Alex





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]