Re: [Nautilus-list] [PATCH]: avoid re-layouting when it's not needed.

On Sunday, June 17, 2001, at 03:58  AM, Yoann Vandoorselaere wrote:

On directory load, we do relayout several time before it's needed
(before any file get added or changed). In fact, in this case, the
files_changed signal should only be hooked after finish_loading is
called (when the view is loaded and we are starting monitoring the
directory), and disconnected as soon as the directory load is done.

This work fine on my local tree, and seem to help with latency.

Can I commit ?

As I said in my previous message, files_changed signals are used to communicate changes after a window is up. For example, if you rename the file using the properties window or in another Nautilus window, or delete a file in another Nautilus window.

So this change is not a safe fix. It breaks other things.

BTW : in the finish_loading function,
      schedule_timeout_display_of_pending_files() get called, but
      it doesn't seem to be needed, as it will get called implicitly
      by the nautilus_directory_file_monitor_add() call and the
      "files_changed" it trigger.

      Do I miss the point here or is it ok to remove it ?

From reading the code it looks like it would be OK to remove it. But you'd need to test afterwards. Good test cases would be empty directories, directories with only one file, very large directories, and remote (WebDAV)
 as well as local directories with FAM on and off.

    -- Darin

PS: I need to leave for the airport now. My wife is pretty angry with me for spending my last few minutes typing email.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]