[Nautilus-list] [PATCH] : fix some memory leak



Hi,

here is a patch that fix some memory leak.
Can I commit ?


-- 
Yoann Vandoorselaere
http://prelude.sourceforge.net
Index: libnautilus-private/nautilus-link.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-link.c,v
retrieving revision 1.57
diff -u -p -r1.57 nautilus-link.c
--- libnautilus-private/nautilus-link.c	2001/05/03 17:33:15	1.57
+++ libnautilus-private/nautilus-link.c	2001/08/27 08:44:02
@@ -237,8 +237,11 @@ local_set_root_property (const char *pat
 	old_value = xmlGetProp (root, key);
 	if (old_value != NULL && strcmp (old_value, value) == 0) {
 		xmlFreeDoc (document);
+		xmlFree (old_value);
 		return TRUE;
 	}
+	
+	xmlFree (old_value);
 
 	/* Change and write the property. */
 	xmlSetProp (root, key, value);
Index: src/nautilus-complex-search-bar.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-complex-search-bar.c,v
retrieving revision 1.51
diff -u -p -r1.51 nautilus-complex-search-bar.c
--- src/nautilus-complex-search-bar.c	2001/08/26 19:01:13	1.51
+++ src/nautilus-complex-search-bar.c	2001/08/27 08:44:03
@@ -456,7 +456,7 @@ load_find_them_pixmap_widget (void)
 	GdkBitmap *mask;
 	
 	pixbuf = gdk_pixbuf_new_from_file (NAUTILUS_PIXMAPDIR "/search.png");
-	if (pixmap != NULL) {
+	if (pixbuf != NULL) {
 		gdk_pixbuf_render_pixmap_and_mask (pixbuf, &pixmap, &mask, EEL_STANDARD_ALPHA_THRESHHOLD);
 		gdk_pixbuf_unref (pixbuf);
 		return gtk_pixmap_new (pixmap, mask);
Index: src/nautilus-switchable-search-bar.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-switchable-search-bar.c,v
retrieving revision 1.26
diff -u -p -r1.26 nautilus-switchable-search-bar.c
--- src/nautilus-switchable-search-bar.c	2001/05/04 10:18:37	1.26
+++ src/nautilus-switchable-search-bar.c	2001/08/27 08:44:03
@@ -115,7 +115,6 @@ nautilus_switchable_search_bar_new (Naut
 {
 	GtkWidget *label;
 	GtkWidget *event_box;
-	GtkWidget *vbox;
 	GtkWidget *hbox;
 	GtkWidget *switchable_search_bar;
 	NautilusSwitchableSearchBar *bar;
@@ -128,7 +127,6 @@ nautilus_switchable_search_bar_new (Naut
 	gtk_container_set_border_width (GTK_CONTAINER (event_box),
 					GNOME_PAD_SMALL);
 	
-	vbox = gtk_vbox_new (0, FALSE);
 	label = gtk_label_new (_("Find:"));
 	gtk_container_add (GTK_CONTAINER (event_box), label);
 	


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]