[Nautilus-list] Thumbnailing bug

Jonathan had problems with nautilus not thumbnailing some files on his 
machine. This was due to a mismatch in the thumbnailing logic. Here is a 

Index: libnautilus-private/nautilus-thumbnails.c
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-thumbnails.c,v
retrieving revision
diff -u -p -r1.24.2.4 nautilus-thumbnails.c
--- libnautilus-private/nautilus-thumbnails.c	2001/08/14 22:45:33
+++ libnautilus-private/nautilus-thumbnails.c	2001/08/17 17:59:43
@@ -377,7 +377,7 @@ nautilus_get_thumbnail_uri (NautilusFile
 	file_uri = nautilus_file_get_uri (file);
-	thumbnail_uri = make_thumbnail_uri (file_uri, FALSE, uri_is_local (file_uri), anti_aliased, TRUE);
+	thumbnail_uri = make_thumbnail_uri (file_uri, FALSE, TRUE, anti_aliased, TRUE);
 	/* if the thumbnail file already exists locally, simply return the uri */

The problem is that uri_is_local() returns FALSE for file: uris that 
specify files on NFS. This means that when nautilus created a local 
thumbnail (local == in .thumbnails in the directory in NFS) it couldn't 
find it when it looked for it, so it kept spinning over and over 
recreating the thumbnail.

I think the patch is correct, because with the patch the behaviour is:
1) look for local thumbnail, if exists and uptodate, just return it.
2) look for global thumbnail, if exists and uptodate, just return it.
3) Look if we can create a local thumbnail.
4) Else do a global one
5) Create it.

This means that that even if we cannot write to the local directory, if 
there is an uptodate thumbnail there we use it.

/ Alex


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]