Re: [Nautilus-list] patch for directory view as list

["John Sullivan" <sullivan eazel com>]

on 10/16/00 12:07 PM, Matt Bissiri at bissiri eecs umich edu wrote:

> Hi John,
> 
> John Sullivan wrote:
> 
>> Hi Matt,
>> 
>> Thanks for catching this problem and writing a patch. Your patch fixes the
>> problem (which, surprisingly, hadn't yet been reported in
>> bugzilla.eazel.com, I don't think). However, rather than just take your
>> patch and forget about the issue for now, I'd prefer that the related code
>> be cleaned up a little more. It's been in a funny state since the creation
>> of nautilus-clist. Specifically, there is no need to have both
>> nautilus_list_get_first_selected_row and
>> nautilus_clist_get_first_selected_row (and the same for _get_last_). The
>> _clist_ flavor is a private function used only once, in a place where the
>> public _list_ version would work just fine (there's already a local variable
>> holding the NautilusList). So we should remove the _clist_ flavor of these
>> two functions and leave just the _list_ flavor.
>> 
>> Also, since we don't use nautilus_gtk_clist_get_first/last_selected_row any
>> more, we should just delete those functions entirely. They will just take up
>> a little space and bit-rot away uselessly otherwise.
>> 
> 
> nautilus_gtk_clist_get_first_selected_row is used in
> libnautilus-extensions/nautilus-program-chooser.c line 729.
> That's why I did not remove the
> `nautilus_gtk_clist_get_(first|last)_selected_row'
> functions in my previous patch.
> 
> [snip]

Good point. I didn't do a search and just jumped to the conclusion that we
weren't using it elsewhere.

>> 
>> Matt, please let me know if you would like me to finish up this
>> first/last_selected_row issue, or whether you would like to do so. I'm happy
>> to take your patch and make the other changes I mentioned. And I'm equally
>> happy to let you do it. Since you found the problem, I'll let you make the
>> call.
>> 
> 
> I've attached an updated patch, following your suggestions above,
> except for removing `nautilus_gtk_clist_get_(first|last)_selected_row' from
> libnautilus-extensions/nautilus-gtk-extensions.[ch]

OK, your updated patch is good. We are talking about rearranging which of
the clist-related code should go where sometime perhaps soon, but in the
meantime your new patch will improve the current situation. Please check it
in, thanks.

John