Re: [Muine] Gconf Key for amazon dev tag



here's a redone patch with the changes to muine.schemas.in included as
well as a patch i found floating around that allowed muine to compile,
it's the last one.

-willis


On Sun, 2005-11-20 at 02:46 -0800, Eric Lesh wrote:
> Martin Willis Monroe wrote:
> > Here's a patch which adds a gconf key for amazon dev tags so you can
> > fetch albums.
> > 
> > I had to add a schema to muine.schemas but cvs diff didn't pick that up
> > (not managed by cvs) I didn't really understand that so here's the basic
> > schema.  Does some other file govern the creation of the schema file?
> 
> Try muine.schemas.in.  The schemas file is generated from that.
> 
> -eric
> 
> 
Index: data/muine.schemas.in
===================================================================
RCS file: /cvs/gnome/muine/data/muine.schemas.in,v
retrieving revision 1.22
diff -u -r1.22 muine.schemas.in
--- data/muine.schemas.in	23 Jan 2005 20:17:17 -0000	1.22
+++ data/muine.schemas.in	20 Nov 2005 18:14:42 -0000
@@ -134,5 +134,16 @@
 	<long>Which Amazon site to use for fetching album images, "us", "uk", "de", or "jp".</long>
       </locale>
     </schema>
+    <schema>
+      <key>/schemas/apps/muine/amazon_dev_tag</key>
+      <applyto>/apps/muine/amazon_dev_tag</applyto>
+      <owner>muine</owner>
+      <type>string</type>
+      <default>amazondevtag</default>
+      <locale name="C">
+      	<short>Amazon Dev Tag</short>
+	<long>Your Amazon Dev Tag for fetching albums</long>
+      </locale>
+    </schema>
   </schemalist>
 </gconfschemafile>
Index: src/CoverGetter.cs
===================================================================
RCS file: /cvs/gnome/muine/src/CoverGetter.cs,v
retrieving revision 1.15
diff -u -r1.15 CoverGetter.cs
--- src/CoverGetter.cs	15 Mar 2005 11:25:47 -0000	1.15
+++ src/CoverGetter.cs	20 Nov 2005 18:14:43 -0000
@@ -34,7 +34,8 @@
 		// GConf
 		private const string GConfKeyAmazonLocale     = "/apps/muine/amazon_locale";
 		private const string GConfDefaultAmazonLocale = "us";
-
+		private const string GConfKeyDevTag = "/apps/muine/amazon_dev_tag";
+		private	const string GConfDefaultDevTag = "amazondevtag";
 		// Delegates
 		public delegate void GotCoverDelegate (Pixbuf pixbuf);
 														
@@ -45,6 +46,7 @@
 
 		// Variables
 		private string amazon_locale;
+		private string dev_tag;
 
 		// Variables :: Cover Filenames
 		//	TODO: Maybe make checking these case-insensitve instead
@@ -297,9 +299,14 @@
 			int current_page = 1;
 			int max_pages = 2; // check no more than 2 pages
 			
+			//Getting the GConf Dev Tag
+			
+		       	dev_tag = (string) Config.Get (GConfKeyDevTag, 
+				GConfDefaultDevTag);
+
 			// Create Encapsulated Request
 			Amazon.ArtistRequest asearch = new Amazon.ArtistRequest ();
-			asearch.devtag = "INSERT DEV TAG HERE"; // TODO: We really should have a devtag
+			asearch.devtag = dev_tag; // TODO: We really should have a devtag
 			asearch.artist = sane_artist;
 			asearch.keywords = sane_album_title;
 			asearch.type = "heavy";
Index: src/PlaylistWindow.cs
===================================================================
RCS file: /cvs/gnome/muine/src/PlaylistWindow.cs,v
retrieving revision 1.236
diff -u -r1.236 PlaylistWindow.cs
--- src/PlaylistWindow.cs	14 Jun 2005 13:37:17 -0000	1.236
+++ src/PlaylistWindow.cs	20 Nov 2005 18:14:45 -0000
@@ -414,7 +414,7 @@
 		public void RestorePlaylist ()
 		{
 			// Load last playlist
-			if (!File.Exists (FileUtils.PlaylistFile))
+			if (!System.IO.File.Exists (FileUtils.PlaylistFile))
 				return;
 
 			OpenPlaylistInternal (FileUtils.PlaylistFile,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]