Re: [Muine] Multimedia Key Support

[Jorn Baayen <jbaayen dds nl>]

Heya!

This rocks. I have some (minor) comments though:

- We can remove the whole KeyPress handler in PlaylistWindow, since it
only handles mm keys anyway which are now handled globally.
- MMKeys should be created in PlaylistWindow instead of Muine. That way
we won't have trouble with having to make all that stuff public.
- mm-keys.{c,h} should use consistent indentation
- Whats with your changes to SeekTo?
- the Refresh thing probably is very confusing.. while I like the idea
we probably shouldn't do it. I found these though, currently not handled
by acme/cc but..:
   XF86XK_Music, XF86XK_AudioMedia

  These should probably toggle main window visibility, or something.


Cheers!

Jorn

On Mon, 2004-03-08 at 21:42 +0000, Lee Willis wrote:

> The patch below adds basic support for the following multimedia keys:
> 
> - Pause (Acts as a Play/Pause toggle as per the Muine toolbar)
> - Next
> - Previous
> 
> There are a few rough edges to be tidied up, namely:
> 
> (1) Once in MmKeys.cs we should probably emit signals rather than
> calling playlist.* directly
> (2) We need to carry out the playlist checks, but we can't really from
> where we are without making lots of stuff unnecessarily public. This
> will probably be solved if we fix (1)
> - It's only been tested on my local machine - all feedback welcome!
> 
> http://www.leewillis.co.uk/muine/mmkeys.patch
> 
> Lee
> 
> _______________________________________________
> muine-list mailing list
> muine-list gnome org
> http://lists.gnome.org/mailman/listinfo/muine-list