Re: new contributor
- From: Vasily Galkin <galkin-vv yandex ru>
- To: Adam Antium <adam0antium gmail com>
- Cc: meld-list <meld-list gnome org>, Kai <kai willadsen gmail com>
- Subject: Re: new contributor
- Date: Fri, 14 Aug 2020 23:05:46 +0300
I've submitted the merge-request, the fix seems to work as expected, however I noticed that the pipeline
failed, even though it seems to be the same code as the forked repo. Is there some setting up in gitlab I
needed to do for that to work?
Regards,Adam
Looking into https://gitlab.gnome.org/adam0antium/meld/-/jobs/855727
```meld/task.py:144:1: I001 isort found an import in the wrong position```
I think that it is caused by some auto-updating of linter code or linter rules.
Currently meld's CI uses "auto-updating" linter, so sometimes new failures appears without chnaging code, but
after just re-running check later.
In this case it seems that linter introduces sorting check for non-top imports.
Just cretaed PR with a trivial fix https://gitlab.gnome.org/GNOME/meld/-/merge_requests/61
Logically, after merging 61 to master the your MR should become green to.
However, technically I'm not sure that gitlab reruns CI the merge-target branch changes.
--
Best regards, Vasily
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]