Re: [PATCH] Fixed closing when saving multiple windows at once



On 16 February 2018 at 07:37, Erik Schilling
<ablu erikschilling gmail com> wrote:
The issue is that if you edit multiple editor panes *with changes*
during a compare / merge session and try to close the window you are
prompted with the Save dialog. If you want to save more than 1 file (2
or 3, does not matter) the save happens but the window does not close.
For a single file with changes it all works as expected.

Ah! Thanks, that helped.

So your patch was very, very close to correct. The only problem with
it was that it wouldn't clear an error state on a successful save.
I've just pushed a closely related fix to master, just being slightly
more specific about when we don't clear the closing state:
    https://gitlab.gnome.org/GNOME/meld/commit/c645afe63a651066cf47888551f2c6cf01879e44

Let me know if that doesn't fix it for you, and I'll have another look.

cheers,
Kai


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]