Re: [PATCH] findbar: Hide when pressing Escape

[Kai Willadsen <kai willadsen gmail com>]

On 23 October 2017 at 12:53, Vladimir Panteleev <git thecybershadow net> wrote:
> Connect a handler for the GTK stop-search signal, and hide the FindBar
> when it is received.
>
> Although there exists code in FileDiff.on_key_event to handle Escape
> key presses, Escape key press events are not propagated when the
> GtkSearchEntry has focus.

Thanks for that! I've just pushed your change to master.

Looking at the API, I feel like we should be using
gtk_search_entry_handle_event() at a higher level, but I couldn't get
that to do what I wanted easily, and your patch is a definite
improvement anyway.

cheers,
Kai