Re:Changes to file loading and saving

[Vasily Galkin <galkin-vv yandex ru>]

> On 22 Dec 2015 6:01 pm, "Vasily Galkin" <galkin-vv yandex ru> wrote:
>
> > Hi.
> >
> > It seems I've encounter a minor issue that doen't present in 3.15.1 but appeared in current master with 
> > file io changed.
> > Informaly it is spurious reload notification that appers nearly everytime after saving file on windows 
> > (gnome libs are PyGI 3.18.2 AIO for Python 2.7 32 bit).
> >
> > It is windows-specific and doesn't arise in linux. Formal steps:
> > - Open meld in 2 files compare mode
> > - Edit one file
> > - Press save on the file's toolbar
> > Actual behaviour: file is always saved. Also most of the times "Do you want to reload the file?" 
> > notification with "Reload" button appears. After reloading all is ok - file is new.
> > Expected behaviour: file is saved, no "Reload" notification button appears.
>
> Okay thanks for that. I remember having to change the notification
> behaviour on Linux for the GtkSourceView changes, so I guess I'm not
> shocked that it's differently broken on windows.
>
> Could I ask you to please file a bug so that this doesn't get lost?
>
> > In previous my letter with patch I was a bit too technical, so this time I'm glad to thank developers for 
> > best-for-me intercative diff viewer/editor/merger and best linux interactive svn client.
>
> Not too technical at all! I just haven't had time to read the patch
> properly yet. Thanks!
>
> cheers,
> Kai

Filed https://bugzilla.gnome.org/show_bug.cgi?id=759851 about this.

Also I found another regression with loading files in meld master, that is not a meld's source bug, but still 
is a regression from 3.15.1 in a user point of view. GtkSourceView has a longstanding problem with analyzing 
only first 8KB of file while determining encoding - it's https://bugzilla.gnome.org/show_bug.cgi?id=598818

So for files that have first 8KB ascii-compatible, the encoding is determined as first-in-encodings-list 
regardless of the folowing content.
While working on huge source files with a small number of comments in native language that are not in first 
8KB encoding detection fails in current master.
Autodection can't be helped with order settings - or different projects files are really in differnt 
encodings.
Not filing this as separate meld bug by now, because currently there is some work done in this area in  - 
https://git.gnome.org/browse/gtksourceview/log/?h=wip/uchardet-2