Re: [PATCH] Make GtkSourceView scheme-style configurable
- From: Kai Willadsen <kai willadsen gmail com>
- To: "Mark R. Pariente" <markpariente gmail com>
- Cc: meld-list <meld-list gnome org>
- Subject: Re: [PATCH] Make GtkSourceView scheme-style configurable
- Date: Fri, 10 Oct 2014 07:09:25 +1000
On 9 October 2014 04:05, Mark R. Pariente <markpariente gmail com> wrote:
Kai, thanks for your detailed review and helpful suggestions. I have
implemented your requests as best as I could - I'm attaching two
patches on top of my original patch + your patch. Please let me know
how it looks.
I've also updated the github pull request at:
https://github.com/GNOME/meld/pull/2 with these patches.
Yeah, those look good to me, thanks. I've just pushed the patch set to
master. Thanks for the feature!
I'm still concerned about interactions between these schemes and our
colours, but I guess we'll figure something out as we go along.
cheers,
Kai
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]