Re: Python diagnostic in vc-mode for git

[Kai Willadsen <kai willadsen gmail com>]

On 16 March 2013 06:43, Daniel Macks <dmacks netspace org> wrote:
> I have a local clone of a github project. 'meld fink-git' (the local directory
> name) or 'meld' and then choosing 'version control view' to select it displays
> "fink-git" with a folder-icon. But if I double-click it, the terminal reports:
>
> Traceback (most recent call last):
>   File "/sw/lib/meld/meld/vcview.py", line 433, in on_row_activated
>     self.run_diff( [path] )
>   File "/sw/lib/meld/meld/vcview.py", line 468, in run_diff
>     comp_path = self.vc.get_path_for_repo_file(path)
>   File "/sw/lib/meld/meld/vc/git.py", line 90, in get_path_for_repo_file
>     raise _vc.InvalidVCPath(self, path, "Path not in repository")
> meld.vc._vc.InvalidVCPath: Git: Path /usr/local/fink/fink-git is invalid or not present
> Error: Path not in repository

Oh that's new... that's a regression in 1.7.1, so thanks for finding it.

> and the GUI does not switch to the repo view. I get the same effect for a
> clone of a git.gnome project. Other VCs seem to work (a CVS checkout
> switches to VC view (expandable tree-view, erc.)

Hey, look at that! I had no idea we did that. That's actually
switching to a single-pane folder comparison. I'm not certain what the
desired behaviour here is, as I don't really understand what the
previous behaviour is good for, but I'm open to explanations.

Anyway, in the interests of not dumping tracebacks, I've pushed a
change to git that restores what I think our previous behaviour was.
Please let me know if it's not right.

cheers,
Kai