Re: Labels do not work when comparing folders

[Angel Ezquerra <angel ezquerra gmail com>]

On Wed, Jan 30, 2013 at 9:00 PM, Kai Willadsen <kai willadsen gmail com> wrote:
> On 29 January 2013 16:44, Angel Ezquerra <angel ezquerra gmail com> wrote:
>> Hi,
>>
>> I just noticed that labels do not work when comparing folders. They
>> seem to be ignored.
>
> No one has put forward a use case for this, so it's just not
> implemented. For stuff this this, please just file a bug.
>
> cheers,
> Kai

OK, I just did, thanks:

https://bugzilla.gnome.org/show_bug.cgi?id=692907

I described the use case on the bug report. The gist of it is that
TortoiseHg (and similar tools) use a directory diff when comparing
whole revisions. Not being able to set the label for directory
comparions makes using meld in that context less than ideal.

BTW, I went through the code briefly. I saw that while
"tab.set_labels(options.label) seems to be called both for file and
folder diffs, the DirDiff class does not seem to have a set_labels()
method, while the FileDiff class does. Also, the recompute_label()
method of these classes is different, only the, with the FileDiff one
reads the labels.

Unfortunatelly I have no experience with GTK so it is a bit hard for
me to go further than that. Plus it is hard to debug because a lot of
GTK error messages are constantly printed into the windows console.

Cheers,

Angel