On 12/12/2012 8:02 AM, "Kai Willadsen" <kai willadsen gmail com> wrote:
>
> So looking at history, we already changed from 'check' to 'status' a
> while ago to make it faster.
> https://bugzilla.gnome.org/show_bug.cgi?id=653302
>
> The idea is that valid_repo() should tell us whether we're actually
> operating in something that bzr recognises as a valid repository. Do
> you think that 'bzr info' is good enough as far as that kind of check
> goes? Basically, we want to know that further bzr calls on that path
> will actually do something sensible.
Info is good enough and *much* quicker imo.
It simply returns parent paths of this branch and so forth.
Other options: root, version-info
If any of these commands succeed, then there is a .bzr directory somewhere in our above this folder, status won't be doing any more about checks than these commands, check is the only command that does integrity checks.
This all said, the patch to remove pipe will make this a non issue, unless we'd like to speed things up a little by not calling status twice.
Louis.