Re: [PATCH] Add flat view mode option to directory diff

[Kai <kai willadsen gmail com>]

On 3 March 2011 01:03, Piotr Piastucki <leech miranda gmail com> wrote:
> Hi,
>
> I'm attaching a patch that adds a flat view mode to dir diff. I found it
> quite useful in some cases, especially when the folder hierarchy is pretty
> complex yet there are few modified files.

I like the feature, I think it's useful, and I'd love to merge it.

However, this patch raises all sorts of issues that ring alarm bells.
The big one is that I'd naively expect that the 'right' way to switch
between flat and tree-based views would be entirely TreeView based,
whereas this patch has a lot of TreeStore-based logic.

It may require some larger changes to the underlying store, but I'd
think that Flatten mode should really be implementable using a
TreeViewFilter and some minor treeview display toggles.

> Moreover, this change makes dir
> diff more consistent with vc view.

In what way? or do you just mean that they now both have "Flatten" buttons?

cheers,
Kai