Re: [PATCH v2 2/3] vc: Check for installed version control tools before use

[Vincent Legoll <vincent legoll gmail com>]

looks good enough for me

On Thu, Aug 19, 2010 at 5:26 AM, Peter Tyser <ptyser gmail com> wrote:
> Hi Vincent,
>
>> looks good, maybe change the combobox's mouseover tooltip to tell the
>> user why the entry is greyed, or something like that
>
> The current patch has the following behavior:
> - The mouseover tooltip of the combobox says "Choose one Version Control"
> - When the combobox is clicked it lists the available version control options
> - If one of the version control tools is not installed, the combobox
> item is greyed out and has a message such as "Subversion (svn Not
> Installed)"
> - Patch 3/3 adds support to detect if a repository is invalid, in
> which case the combobox item is greyed out and says "Subversion
> (Invalid Repository)"
>
> So I attempted to make it clear to a user why they can't select a
> greyed out combobox selection.  Does the current behavior seem
> sufficient?  Or did you have a suggestion about how it could be
> improved?
>
> Thanks,
> Peter
>



-- 
Vincent Legoll