Re: [PATCH] Make filediff viewers adjustable widths

[Mark Doliner <mark kingant net>]

On Sun, Mar 29, 2009 at 4:19 AM, Kai Willadsen <kai willadsen gmail com> wrote:
> 2009/3/27 Mark Doliner <mark kingant net>:
>> I filed a bug in your bug tracker with a patch for this, but I thought
>> I'd send an email here, too:
>> http://bugzilla.gnome.org/show_bug.cgi?id=576934
>>
>> I'm not good at describing this, and a picture is worth 1000 words, so:
>> http://bugzilla.gnome.org/attachment.cgi?id=131487
>>
>> Thinking about this change in your head it doesn't seem like a
>> necessity.  But once you've used it a little bit you get used to it
>> and realize just how awesome it is :-)
>
> This seems pretty cool. My only real problem with it is that the pane
> adjustments break the appearance of the central bar and take up
> horizontal space.
>
> I think it should be possible to pack the pane adjustment grippy
> *above* the diffbar, between the two file entries. This would leave
> the nice rendering intact, should look better since you could center
> it over the diffbar, and wouldn't take up any additional horizontal
> space.

I agree, it would look better if the adjustment grippy was centered in
the diffbar and didn't break the appearance of the central bar.  But
that sounds hard and I was just scratching an itch.

I'm not familiar with how the diffbar is implemented.  Is it a custom
widget?  It seems like it would need to be extended to display the
grippy image in the middle, and to handle mouse drag/undrag events.
I'm not sure how feasible that is, or how easy it would be to
implement.

-Mark