Re: [PATCH] Vcview should not use knowledge of historyentry's internals
- From: Vincent Legoll <vincent legoll gmail com>
- To: Kai Willadsen <kai willadsen gmail com>
- Cc: meld-list <meld-list gnome org>
- Subject: Re: [PATCH] Vcview should not use knowledge of historyentry's internals
- Date: Tue, 24 Mar 2009 09:46:41 +0100
On Tue, Mar 24, 2009 at 8:39 AM, Kai Willadsen <kai willadsen gmail com> wrote:
> 2009/3/24 Vincent Legoll <vincent legoll gmail com>:
>> I think vcview should use historyentry the same way as dirdiff & filediff,
>> by using its exposed API methods and not directly poking at its internals.
>> This is a no-op fix that is orthogonal to other historyentry.py work
>> and I think it
>> should go in regardless of the other patches.
>> Nothing is changed by that patch, the same code is executed, we just don't
>> open code historyfileentry behavior in vcview, we just use the provided API.
> Looks good. However, with the change I just suggested for moving the
> history saving to happen on entry activation, the set filename here
> won't be saved into the history. Looking at it, I think that this
> (i.e., not saving) is the behaviour I'd expect, but I'm not certain.
I think we should save, and if we don't do it automatically in HFE, which
is OK by me, the class should provide an API for users to do it manually,
and I think that all the callers should do it, be it vcview, filediff
I'll resend the patch series with this in mind.
But I think this patch should go in as-is anyways, whatever we want to do
for history saving...
] [Thread Prev