Re: [PATCH] historyentry work

[Kai Willadsen <kai willadsen gmail com>]

2009/3/24 Vincent Legoll <vincent legoll gmail com>:
> OK, I just resent the behavioral changes I wanted, and left the API
> consistency part of it, which is orthogonal, and which I have trouble
> understanding anyways: the gtk_entry and gnome_entry magic
> make me stare at strange backtraces for a moment before dropping
> the subject into a "to investigate" TODO list entry.

Right. These are gobject properties, and there isn't a lot of
documentation on how exactly they work in python, and how they work
has changed over time. The really confusing bit is that they're also
methods... and that was a bad bit of naming on my part.

(Replying to the other bits on the actual patch emails.)

> I don't undestand what change is needed to NewDocDialog.on_response()
> it looks fine as-is. What did I miss ?

In NewDocDialog, history is appended to an entry when the user selects
"OK". However, the history will have already been appended by the
activate callback. The uniqueness handling in HistoryEntry helps
here... but it still seems a little odd.

Kai