Re: [RFC][PATCH] Add --auto-close command line option

[Kai Willadsen <kai willadsen gmail com>]

2009/3/12 Vincent Legoll <vincent legoll gmail com>:
> The attached patch implements an auto-close option for
> meld, to eventually use for automated testing purposes.
>
> I intend to automate VC plugin testing, for a start and
> this work is the first step in that direction.

I can imagine that this could also be cool for regression testing,
though I suspect that that would require adding quite a few hooks that
aren't there yet.

> It does open diffs specified on command-line, and then
> afterwards close each diff view, being a filediff, a vcview,
> and then finally closes meld itself. The --auto-compare
> command line option still works and is complementary
> to --auto-close.

I don't think this should be a command-line option, simply because
it's not something a user should ever touch, and it's not
functionality that needs to be easily accessible. I guess it could be
a hidden option, but I think that using an environment variable or
similar would be cleaner.

> - Use knowledge of vcview, diffview, meldapp internals in
> gnomeglade.Component, maybe I should have added
> a get_scheduler() API...

Might this fit better in MeldDoc?

> Could you please tell me if you think of better ways
> to do the same. In fact any comment would be
> appreciated on the patch. Any ideas of additional
> features.

I imagine that it should be possible to separate this out into a
testing module that just attaches the necessary handlers, rather than
adding this code to the classes themselves. However, I haven't tried
to do this, so there are probably unforeseen issues.

Kai