Re: [PATCH] undefined variable in dirdiff.py ?

[Vincent Legoll <vincent legoll gmail com>]

On Wed, Mar 11, 2009 at 10:10 AM, Stephen Kennedy <stevek gnome org> wrote:
>> <vincent legoll gmail com> wrote:
>>> The k variable seems undefined at that place, maybe key was intended here ?
>>
>> Steve, could you have a look at this one, I think I don't fully
>> understand what that code is, or should be doing...
>
> Whoa, did I write that? The idea is that when we examine a folder
> case-insensitively, and there is a file missing in one pane, we need
> to pick one of the other filenames to display with strikethrough.
>
> The array of tuples initially contains some "None" items which
> we replace arbitrarily with one of the other items. Looking again,
> I don't see how "or k" can ever be evaluated, since there should be
> at least one non-none element in each tuple.

So, my patch is wrong and we should instead remove the "or k" part
of the expression ?

I'll stare at the thing again, to see if I can understand it better this
time...

Thanks

-- 
Vincent Legoll