Reworking diffutil.Differ



Hi,

I've been looking a little bit at diffutil.py, which is our wrapper
around python's difflib. This does a lot of stuff, and has a lot of
small closely-related functions. It also probably has the biggest
potential for improved performance, either by doing less work, or by
threading it. As such, I've started to do some cleanup and
simplification of the existing code.

I'm attaching a couple of starting patches for review. The first
removes most of the Differ initialisation code, since Differ is never
actually created with sequence arguments. The second patch slightly
reworks the logic of Differ.set_sequences_iter() to be a little more
straightforward.

As it's core code, comments would be appreciated.

cheers,
Kai

Attachment: DifferInitialisation.patch
Description: Binary data

Attachment: DifferSequenceInit.patch
Description: Binary data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]