Re: [PATCH] Remove unused STATE_* imports



2009/2/26 Vincent Legoll <vincent legoll gmail com>:
> Keep only the used ones: STATE_{ERROR,EMPTY,MAX}
> don't clutter the namespace needlessly

While it would be a much more significant change, in my opinion the
actual problem is that the STATE_* constants are all defined in the
wrong place. These should probably be defined in tree.py and imported
into _vc.py. Most of these states have nothing to do with VC in
general, and they're used in VcView and DirDiff as well as all of the
VC plugins. Having said that, maybe it's not actually worth fixing...

Kai


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]