Re: [PATCH] Argument number differ from overridden method

[Vincent Legoll <vincent legoll gmail com>]

On Thu, Feb 26, 2009 at 10:44 PM, Kai Willadsen <kai willadsen gmail com> wrote:
> 2009/2/26 Vincent Legoll <vincent legoll gmail com>:
>> Filediff overrides save() & save_as() from MeldDoc
>> but with differing number of arguments.
>
> I haven't checked thoroughly, but it looks to me as though the correct
> fix is the other way around. I can't see anywhere that needs save()
> and save_as() to accept the extra arguments, so they should probably
> be removed from FileDiff instead.

I was assuming it was because those methods were used as callbacks
from GUI or something. But a grep tends to go in your direction.

So I'll rework the patch the other way around and resend.

-- 
Vincent Legoll