Re: [PATCH] using variable out of scope in diffutil.py ?
- From: Vincent Legoll <vincent legoll gmail com>
- To: Kai Willadsen <kai willadsen gmail com>
- Cc: meld-list gnome org
- Subject: Re: [PATCH] using variable out of scope in diffutil.py ?
- Date: Sun, 15 Feb 2009 14:37:48 +0100
On Sun, Feb 15, 2009 at 2:33 PM, Kai Willadsen <kai willadsen gmail com> wrote:
> 2009/2/15 Vincent Legoll <vincent legoll gmail com>:
>> Here we should use the lambda variable instead of an outer scope
>> variable, I think...
>
> I think the correct fix here would be to absorb the lambda into the
> one-and-only place that it's used (three lines below). Using a lambda
> here at all seems to me to be a net readability loss.
Agreed, I'll do it and resend an updated patch later
--
Vincent Legoll
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]