Hello Jindrich, On Thu, 09 Mar 2006 16:03:30 +0100 Jindrich Novy <jnovy redhat com> wrote:
Hello Pavel, On Thu, 2006-03-09 at 15:14 +0200, Pavel Tsekov wrote:The question is whether to fix the bug in the way that: 1. "Ok" sets the parameters only for the current session and won't touch the ini file. "Save" saves the configuration to ini file so that it's needed to add the "Save" button to the rest of the Options dialog entries to make it consistent. 2. "Ok" sets the parameters to ini file for all the dialogs, so that it's needed to remove "Save" button from the Layout and Configuration options to make it consistent. What's your opinion?I think solution number 2 is better. After all we have Options -> Save setup so the "Save" buttons are somewhat redundant. There is also the auto_save_setup option which saves the ini file on exit.I also prefer this solution as the implementation of the Save button is kind of strange because the Save button is handled by B_EXIT action in init_layout() and layout_cmd() and is rather useless in general ;-)
Yes, and IMO having the optional auto-save-when-exiting is fine, since we have "save setup" from the Options menu, no need for a Save button in *some* options dialog :-). Regards, -- wwp
Attachment:
signature.asc
Description: PGP signature