Re: [Midnight Commander] #149: files with whitespaces as start won't work via fish

["Ticket System" <tickets midnight-commander org>]

#149: files with whitespaces as start won't work via fish
---------------------------------------------------+------------------------
  Reporter:  Patrick Winnertz <winnie debian org>  |       Owner:  winnie  
      Type:  defect                                |      Status:  accepted
  Priority:  major                                 |   Milestone:  4.6.2   
 Component:  vfs                                   |     Version:  4.6.1   
Resolution:                                        |    Keywords:  review  
  Blocking:  10                                    |   Blockedby:  157     
---------------------------------------------------+------------------------
Changes (by slyfox):

  * keywords:  => review


Old description:

> Hey,
>
> Currently it is not possible to do any action on a file which starts
> white a
> whitespace.
> I fixed the issue in Debian with a patch which adds quotes around every
> file.
>
> This works very well.. the drawback is that the -Q option for ls is not a
> standard and is only used on linux hosts.
> Therefore this patch has to be changed slightly to do not fail on non-
> linux
> hosts. This patch needs two functions which are introduced in #147,
> therefore
> we need to solve this ticket before this one can be solved.
>
> This patch won't apply on mc-4.6 I guess as it was written for an earlier
> version of mc. I'll update it afterwards.
>
> Greetings
> Winnie

New description:

 Hey,

 Currently it is not possible to do any action on a file which starts white
 a
 whitespace.
 I fixed the issue in Debian with a patch which adds quotes around every
 file.

 This works very well.. the drawback is that the -Q option for ls is not a
 standard and is only used on linux hosts.
 Therefore this patch has to be changed slightly to do not fail on non-
 linux
 hosts. This patch needs two functions which are introduced in #147,
 therefore
 we need to solve this ticket before this one can be solved.

 This patch won't apply on mc-4.6 I guess as it was written for an earlier
 version of mc. I'll update it afterwards.

 Greetings
 Winnie

--

Comment:

 vfs/fish.c: All escaping stuff was overhauled. The current idea is not to
 use quotes, but use proper shell escaping (quotes break ls for example, it
 can't parse something like this: '''ls " a-> b\"\"\""''').

 All fish ops(chown, rmdir, rm, stor, retr) were converted to use
 <mhl/escape.h>, removed escape nesting.

 Current patchset is at branch:10_fish_whitespace_symlink_issue

 Please review and test!

-- 
Ticket URL: <www.midnight-commander.org/ticket/149#comment:6>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center