Re: [Midnight Commander] #174: (mandriva) set pty fd (on subshell) to closeonexec

["Ticket System" <tickets midnight-commander org>]

#174: (mandriva) set pty fd (on subshell) to closeonexec
----------------------+-----------------------------------------------------
  Reporter:  metux    |       Owner:        
      Type:  defect   |      Status:  new   
  Priority:  major    |   Milestone:  4.7   
 Component:  mc-core  |     Version:  4.6.1 
Resolution:           |    Keywords:  review
  Blocking:           |   Blockedby:        
----------------------+-----------------------------------------------------
Changes (by metux):

  * keywords:  => review


Old description:

> Patch from mandriva:
>
> Set the subshell pty to close-on-exec
>

> --- mc-2006-11-14-16/src/subshell.c.desleak     2006-05-08
> 22:59:48.000000000 +0200
> +++ mc-2006-11-14-16/src/subshell.c     2006-11-23 09:50:30.000000000
> +0100
> @@ -1150,6 +1152,7 @@
>  #endif                         /* I_FIND && I_PUSH */
>  #endif                         /* __osf__ || __linux__ */
>
> +    fcntl(pty_slave, F_SETFD, FD_CLOEXEC);
>      return pty_slave;
>  }
>
> @@ -1203,6 +1207,7 @@
>      }
>      if ((pty_slave = open (pty_name, O_RDWR)) == -1)
>         fprintf (stderr, "open (pty_name, O_RDWR): %s\r\n", pty_name);
> +    fcntl(pty_slave, F_SETFD, FD_CLOEXEC);
>      return pty_slave;
>  }

New description:

 Patch from mandriva:

 Set the subshell pty to close-on-exec

 changeset:9f369abe25277eff2be9164f032c530fd425e889

 --- mc-2006-11-14-16/src/subshell.c.desleak     2006-05-08
 22:59:48.000000000 +0200
 +++ mc-2006-11-14-16/src/subshell.c     2006-11-23 09:50:30.000000000
 +0100
 @@ -1150,6 +1152,7 @@
  #endif                         /* I_FIND && I_PUSH */
  #endif                         /* __osf__ || __linux__ */

 +    fcntl(pty_slave, F_SETFD, FD_CLOEXEC);
      return pty_slave;
  }

 @@ -1203,6 +1207,7 @@
      }
      if ((pty_slave = open (pty_name, O_RDWR)) == -1)
         fprintf (stderr, "open (pty_name, O_RDWR): %s\r\n", pty_name);
 +    fcntl(pty_slave, F_SETFD, FD_CLOEXEC);
      return pty_slave;
  }

--

-- 
Ticket URL: <www.midnight-commander.org/ticket/174#comment:1>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center