Re: [Midnight Commander] #268: [PATCH] Allow using SI-based size prefixes



#268: [PATCH] Allow using SI-based size prefixes
--------------------------+-------------------------------------------------
  Reporter:  bilbo        |       Owner:  bilbo   
      Type:  enhancement  |      Status:  accepted
  Priority:  major        |   Milestone:  4.7     
 Component:  mc-core      |     Version:  4.6.2   
Resolution:               |    Keywords:  rework  
  Blocking:               |   Blockedby:          
--------------------------+-------------------------------------------------

Comment(by slyfox):

 > What do you mean by 'nongettextized "M" and "K" duplication' ?

 Ideally,
 >               {"", "k", "m", "g", "t", "p", "e", "z", "y", NULL};
 could be internationalized via gettext (in far future :])

 and this looks like identifier duplication:
 >        xtra = kilobyte_si?"k":"K";
 ...
 >        xtra = kilobyte_si?"m":"M";

 can be changed to suffix[1,2]/suffix_ic[1,2] (with little code
 restructurements: move suffix* definitions upper). But will it be more
 readable?

 Tried to apply patch and didn't find this config option in menus. Is it
 intended for use in '~/.mc/ini' file only?

-- 
Ticket URL: <www.midnight-commander.org/ticket/268#comment:5>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]