Re: [Midnight Commander] #229: ncurses "default color" change to -1 when available



#229: ncurses "default color" change to -1 when available
--------------------------------------------+-------------------------------
  Reporter:  robert david public gmail com  |       Owner:        
      Type:  defect                         |      Status:  new   
  Priority:  major                          |   Milestone:  4.6.3 
 Component:  mc-core                        |     Version:  4.6.1 
Resolution:                                 |    Keywords:  review
  Blocking:                                 |   Blockedby:        
--------------------------------------------+-------------------------------
Changes (by metux):

  * keywords:  => review
  * milestone:  4.7 => 4.6.3


Old description:

> When using ncurses, there is problem with setting default color to
> transparent on capable terminals. This is caused by color index going
> from 0+ but the default terminal color is -1 in ncurses. So mc doesnt
> show true default color, but BLACK. [[BR]]
>
> This also has to be dependant on terminal support, if it supports default
> colors or not. Good inspiration about this is in htop source -> CRT.c ->
> CRT_setColors

New description:

 When using ncurses, there is problem with setting default color to
 transparent on capable terminals. This is caused by color index going from
 0+ but the default terminal color is -1 in ncurses. So mc doesnt show true
 default color, but BLACK. [[BR]]

 This also has to be dependant on terminal support, if it supports default
 colors or not. Good inspiration about this is in htop source -> CRT.c ->
 CRT_setColors

 ----

 branch:229_ncurses_colors
 changeset:2f2acb9a0aa2c403d4257a682ebb98d134a48cfd

--

Comment:

 as its a bug, moving to 4.6.3

-- 
Ticket URL: <www.midnight-commander.org/ticket/229#comment:1>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]