Re: [Midnight Commander] #118: savannah: cannot specify port number in shell link

["Ticket System" <tickets midnight-commander org>]

#118: savannah: cannot specify port number in shell link
--------------------------+-------------------------------------------------
  Reporter:  slavazanko   |       Owner:  metux                                
      Type:  enhancement  |      Status:  testing                              
  Priority:  major        |   Milestone:  4.7                                  
 Component:  vfs          |     Version:  4.6.1                                
Resolution:  fixed        |    Keywords:  vote-styx vote-metux committed-master
  Blocking:               |   Blockedby:                                       
--------------------------+-------------------------------------------------
Changes (by metux):

  * keywords:  vote-styx vote-metux approved => vote-styx vote-metux
               committed-master
  * status:  accepted => testing
  * resolution:  => fixed


Old description:

> Original: http://savannah.gnu.org/bugs/?18042
>
> ||Submitted by:||Palo Simo <palos>||
> Submitted on:||Tue 17 Oct 2006 12:51:17 PM UTC||
> ||Category:||VFS||Severity:||3 - Normal||
> ||Status:||Ready For Test||Privacy:||Public||
> ||Assigned to:||Andrew V. Samoilov <sav>||Open/Closed:||Open||
> ||Release:||current (CVS or snapshot)||Operating System:||All||
>
> Discussion:
> {{{
> Mon 30 Oct 2006 08:11:45 PM UTC, comment #4:
>
> Thank you for the patch, it is working okay, great!
> I do not use any of the other options, so I don't know if they are
> affected - I think you know whether or not ...
>         Palo Simo <palos>
> Mon 30 Oct 2006 12:04:54 PM UTC, comment #3:
>
> > Do I understand correctly that a port number can be combined with C or
> r? And does one have to specify a port number if one uses 'r'? Please
> explain any syntax changes that you introduced.
>

> No. Look at utilvfs.c:vfs_split_url().
> No one syntax change. Only undocumented behaviour changed.
> It is possible to use /#sh:user host:6789 right now.
> And fish uses port&1 as 'C' option and port&2 as 'r'.
>
> Possible solution is to use 0x10000<<1 and 0x10000<<2 instead of 1 and 2.
>
> > From what I remember from earlier investigations to separate out the
> port from the other options we need to add an extra variable to some of
> the functions. Am I mistaken?
>

> You are right.
>
> > Maybe it's best first to decide on a new option syntax that allows all
> combinations and then implement that new syntax?
>

> I am not sure we can allow such redesign because of lack of manpower.
>         Andrew V. Samoilov <sav>
> Project MemberIn charge of this item.
> Sat 28 Oct 2006 12:43:20 PM UTC, comment #2:
>
> > Weakness: port number
> > and r and C option cannot be used together.
> > Port 1 will be interpretted as 'C' option, port 2 as 'r'.
>

> Do I understand correctly that a port number can be combined with C or r?
> And does one have to specify a port number if one uses 'r'? Please
> explain any syntax changes that you introduced.
>
> From what I remember from earlier investigations to separate out the port
> from the other options we need to add an extra variable to some of the
> functions. Am I mistaken?
>
> Maybe it's best first to decide on a new option syntax that allows all
> combinations and then implement that new syntax?
>         Leonard den Ottolander <leonardjo>
> Project Member
> Fri 27 Oct 2006 12:15:02 PM UTC, comment #1:
>
> Hello, Palo.
>
> Please test attached patch. This changes have to be documented in manuals
> before commit to CVS.
>
> vfs/ChangeLog:
>
>     * fish.c: Iterpret SUP.flags as port number if SUP.flags is not in 0,
> FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number
>
> and r and C option cannot be used together.
> Port 1 will be interpretted as 'C' option, port 2 as 'r'.
>
> (fish_open_archive_int): Change for above.
> (fish_fill_names): Likewise.
>         Andrew V. Samoilov <sav>
> Project MemberIn charge of this item.
> Tue 17 Oct 2006 12:51:17 PM UTC, original submission:
>
> this is a feature request:
> include the ability to specify port number to connect to in the shell
> link to machine feature
> }}}

New description:

 Original: http://savannah.gnu.org/bugs/?18042

 ||Submitted by:||Palo Simo <palos>||
 Submitted on:||Tue 17 Oct 2006 12:51:17 PM UTC||
 ||Category:||VFS||Severity:||3 - Normal||
 ||Status:||Ready For Test||Privacy:||Public||
 ||Assigned to:||Andrew V. Samoilov <sav>||Open/Closed:||Open||
 ||Release:||current (CVS or snapshot)||Operating System:||All||

 Discussion:
 {{{
 Mon 30 Oct 2006 08:11:45 PM UTC, comment #4:

 Thank you for the patch, it is working okay, great!
 I do not use any of the other options, so I don't know if they are
 affected - I think you know whether or not ...
         Palo Simo <palos>
 Mon 30 Oct 2006 12:04:54 PM UTC, comment #3:

 > Do I understand correctly that a port number can be combined with C or
 r? And does one have to specify a port number if one uses 'r'? Please
 explain any syntax changes that you introduced.


 No. Look at utilvfs.c:vfs_split_url().
 No one syntax change. Only undocumented behaviour changed.
 It is possible to use /#sh:user host:6789 right now.
 And fish uses port&1 as 'C' option and port&2 as 'r'.

 Possible solution is to use 0x10000<<1 and 0x10000<<2 instead of 1 and 2.

 > From what I remember from earlier investigations to separate out the
 port from the other options we need to add an extra variable to some of
 the functions. Am I mistaken?


 You are right.

 > Maybe it's best first to decide on a new option syntax that allows all
 combinations and then implement that new syntax?


 I am not sure we can allow such redesign because of lack of manpower.
         Andrew V. Samoilov <sav>
 Project MemberIn charge of this item.
 Sat 28 Oct 2006 12:43:20 PM UTC, comment #2:

 > Weakness: port number
 > and r and C option cannot be used together.
 > Port 1 will be interpretted as 'C' option, port 2 as 'r'.


 Do I understand correctly that a port number can be combined with C or r?
 And does one have to specify a port number if one uses 'r'? Please explain
 any syntax changes that you introduced.

 From what I remember from earlier investigations to separate out the port
 from the other options we need to add an extra variable to some of the
 functions. Am I mistaken?

 Maybe it's best first to decide on a new option syntax that allows all
 combinations and then implement that new syntax?
         Leonard den Ottolander <leonardjo>
 Project Member
 Fri 27 Oct 2006 12:15:02 PM UTC, comment #1:

 Hello, Palo.

 Please test attached patch. This changes have to be documented in manuals
 before commit to CVS.

 vfs/ChangeLog:

     * fish.c: Iterpret SUP.flags as port number if SUP.flags is not in 0,
 FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number

 and r and C option cannot be used together.
 Port 1 will be interpretted as 'C' option, port 2 as 'r'.

 (fish_open_archive_int): Change for above.
 (fish_fill_names): Likewise.
         Andrew V. Samoilov <sav>
 Project MemberIn charge of this item.
 Tue 17 Oct 2006 12:51:17 PM UTC, original submission:

 this is a feature request:
 include the ability to specify port number to connect to in the shell link
 to machine feature
 }}}

 committed-master
 changeset:a1b47185c952e9d31607d59420a0cb86e9f492ab

--

-- 
Ticket URL: <www.midnight-commander.org/ticket/118#comment:4>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center