Re: [Midnight Commander] #180: (mandriva) concat_dir_and_file() + NULL parameter fix

["Ticket System" <tickets midnight-commander org>]

#180: (mandriva) concat_dir_and_file() + NULL parameter fix
----------------------+-----------------------------------------------------
  Reporter:  metux    |       Owner:  metux                            
      Type:  defect   |      Status:  reopened                         
  Priority:  major    |   Milestone:  4.6.2                            
 Component:  mc-core  |     Version:  4.6.1                            
Resolution:           |    Keywords:  committed-mc-4.6 committed-master
  Blocking:           |   Blockedby:                                   
----------------------+-----------------------------------------------------
Changes (by andrew_b):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Replying to [comment:4 metux]:
 > I've reworked the whole function and replaced it by
 mhl_str_dir_plus_file() in mhl/string.h

 First:
 {{{
 charsets.o: In function `load_codepages_list':
 /home/andrew/work.c/mc/mc.master/src/charsets.c:51: undefined reference to
 `mhl_str_dir_plus_file'
 ../vfs/libvfs-mc.a(smbfs.o): In function `smbfs_get_path':
 /home/andrew/work.c/mc/mc.master/vfs/smbfs.c:1214: undefined reference to
 `mhl_str_dir_plus_file'
 collect2: ld returned 1 exit status
 }}}

 #include <mhl/string.h> is forgotten in those files.

 Second: in mhl_str_dir_plus_file() there are incorrect type of strlen()
 results: int instead of size_t.

-- 
Ticket URL: <www.midnight-commander.org/ticket/180#comment:8>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center