Re: updated: [80a6897] cleanup: mhl_str_dir_plus_file(): int -> size_t (suggested by Andrew Borodin)



On Sun, 1 Feb 2009 21:15:20 +0100
Oswald Buddenhagen <ossi kde org> wrote:

> On Sun, Feb 01, 2009 at 09:02:10PM +0100, Sergei Trofimovich wrote:
> > +    while (...)
> >  	...;
> >  
> > +    size_t fnlen = ...;
> >  
> i should point out that this is C99 and consequently won't compile on
> many platforms with older compilers.

Are you about size_t, or declaring local variable in the middle of function?
Which widely available compilers fail to build this? 
I'd like to setup ones to test buildability, or it's just -ansi -pedantic
options for gcc?

This is not the first time we introduce such problems. I agree - we
should avoid those if it does not hurt (like 'long long' absence or such).

Thanks!
-- 

  Sergei

Attachment: signature.asc
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]