order of buttons in Edit->Quit

In mc's internal editor, the dialog about unsaved file on quit has an
unusual order of buttons: the first and default one is "Cancel quit".
In all other editors I've seen (including Norton Commander and clones)
the default action is "Save file". Moreover this is inconsistent with other
parts of MC itself (consider, for example, Copy File dialog when
a target exists - the default is "Overwrite", not "Abort").
This default action is also useless because there is always a standard
cancel key (F10, Esc) in any context.

I use the attached patch to change it to the "classic" behavior. If this change
is not acceptable, can this dialog be made configurable?

I am using a packaged version of mc from Ubuntu. The output of mc -V is:

GNU Midnight Commander 4.6.1
Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, smbfs
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support

Please Cc me on replies.
--- mc-4.6.1/edit/editcmd.c.-quit	2005-05-27 18:19:18.000000000 +0400
+++ mc-4.6.1/edit/editcmd.c	2008-02-01 04:26:56.000000000 +0300
@@ -2109,18 +2109,18 @@
     switch (edit_query_dialog3
 	    (_("Quit"), _(" File was modified, Save with exit? "),
-	     _("&Cancel quit"), _("&Yes"), _("&No"))) {
-    case 1:
+	     _("&Yes"), _("&No"), _("&Cancel quit"))) {
+    case 0:
 	edit_push_markers (edit);
 	edit_set_markers (edit, 0, 0, 0, 0);
 	if (!edit_save_cmd (edit))
 	    return 0;
-    case 2:
+    case 1:
 	if (edit->locked)
 	    edit->locked = edit_unlock_file (edit->filename);
-    case 0:
+    case 2:
     case -1:
 	return 0;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]