Re: [PATCH] cons.saver: non-blocking console
- From: Miguel de Icaza <miguel novell com>
- To: weigelt metux de
- Cc: midnight commander devel <mc-devel gnome org>
- Subject: Re: [PATCH] cons.saver: non-blocking console
- Date: Mon, 29 Dec 2008 12:42:56 -0500
Opening the console in non-blocking mode is a bad idea, as it means
that every call that is done later on the console_fd needs to check for
EWOULDBLOCK. Most of the time, it would be not return that, it would
only return that under unique situations which means that testing this
patch would not only be non-trivial, but someone would have to audit all
the code paths.
Also, this is lacking a ChangeLog explaining why this is needed.
But I think that this patch should not be applied, it seems like a
workaround that has not been properly implemented.
] [Thread Prev