Re: Various small fixes to 4.6.2-pre1

[Oswald Buddenhagen <ossi kde org>]

On Fri, Nov 02, 2007 at 11:42:27AM +0100, Vladimir Nadvornik wrote:
> On ??tvrtek 01 listopad 2007, Oswald Buddenhagen wrote:
> > On Thu, Nov 01, 2007 at 04:48:02PM +0100, Vladimir Nadvornik wrote:
> > > --- mc-4.6.2-pre1/vfs/smbfs.c
> > > -    result = g_strconcat (my_remote, trailing_asterik ? "/*" : "", 0);
> > > +    result = g_strconcat (my_remote, trailing_asterik ? "/*" : "", (char
> > > *) NULL);
> >
> > the use of NULL is discouraged, at least in c++. it doesn't add value
> > anyway.
> 

> (char *) 0 is also OK.
>
yes.

> However the original is not OK,
>
nobody claimed the opposite. ;)

anyway, if you google for "x null vs. zero", you'll find a helluva lot
of bikeshedding over this issue. :)

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.